Controller position stream #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this an API that flutter_map needs to provide. Can't users choose to use |
|
There's now a sample that shows how to do this with package:location: #447 |
|
Its not exactly the same problem. My PR was just to be able to subscribe the map position, was able to do it on my side, but i think was a nice feature to add |
|
I see, thanks for the clarification |
|
Can you fix the merge conflicts? |
johnpryan
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we need to do something when the map position changes.
It can be done at map level using
onPositionChangedor on plugins with therebuildstream.But i think it should be possible to be notified of map changes with the controller.
I thought about reusing the existing
_onMoveSinkand changing its type fromNulltoMapPositionand that might be a breaking change?The example will not run because it depends on androidX that i added on PR #504